forked from symfony/symfony-docs
-
Notifications
You must be signed in to change notification settings - Fork 0
Add more details to TypeInfo documentation #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Korbeil
wants to merge
201
commits into
7.2
Choose a base branch
from
feature/type-info-updates
base: 7.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 5.4 branch. Discussion ---------- Fix error_pages.rst setResponse() I believe symfony#13877 should not have been merged because `setException` has been replaced by `setThrowable`, not `setResponse`. Commits ------- 8905736 Fix error_pages.rst setResponse()
* 5.4: Fix error_pages.rst setResponse()
* 6.4: Fix error_pages.rst setResponse()
* 7.1: Fix error_pages.rst setResponse()
…er (wouterj) This PR was merged into the 6.4 branch. Discussion ---------- Combine component and framework docs for Serializer A very early PR, to avoid someone else working on this as well (especially `@fabpot` who is on fire with this type of PRs lately). The serializer docs are the most unfortunate component - framework documentation situations I think, with most of the docs in the component docs instead of framework one. This PR is focused on combining all the information in the framework guide as a start. closes symfony#17814 Commits ------- 8a1497b Combine component and framework docs for Serializer
* 6.4: Combine component and framework docs for Serializer
* 7.1: Combine component and framework docs for Serializer
* 7.1: Syntax fixes
a8425ee
to
e8ed9bc
Compare
e8ed9bc
to
dc999f3
Compare
…luz) This PR was merged into the 6.4 branch. Discussion ---------- Use non-static PHPUnit assert methods Fixes symfony#20392. Commits ------- bb77024 Use non-static PHPUnit assert methods
* 6.4: Use non-static PHPUnit assert methods
* 7.1: Use non-static PHPUnit assert methods
…ing comment (alamirault) This PR was merged into the 6.4 branch. Discussion ---------- Replace annotation to attribute in form unit testing comment Commits ------- a51974c Replace annotation to attribute in form unit testing comment
This PR was merged into the 5.4 branch. Discussion ---------- update controller return value A controller is not required to return a `Response` object anymore. Commits ------- 42b4c95 update controller return value doc
* 5.4: update controller return value doc
* 6.4: update controller return value doc Replace annotation to attribute in form unit testing comment
* 7.1: update controller return value doc Replace annotation to attribute in form unit testing comment
…tives (TimoBakx) This PR was merged into the 6.4 branch. Discussion ---------- Added replacement suggestions for forbidden directives Also bumped DOCtor RST workflow to 1.64.0 to allow this (see OskarStark/doctor-rst#1901). Commits ------- 35a3db1 Added replacement suggestions for forbidden directives
* 6.4: Added replacement suggestions for forbidden directives
* 7.1: Added replacement suggestions for forbidden directives
This PR was merged into the 6.4 branch. Discussion ---------- Remove obsolete whitelist entry  Commits ------- fd5d5bb Remove obsolete whitelist entry
* 6.4: Remove obsolete whitelist entry
* 7.1: Remove obsolete whitelist entry
…oesn't have docs (javiereguiluz) This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] [Mesenger] Mention that some option doesn't have docs I tried to find docs for this, but it's really hard. In the Symfony Code, the "docs" just point to this file: https://github.com/php-amqp/php-amqp/blob/latest/amqp_connection_resource.h So, let's at least add the text saying that "there's no docs" so the page design doesn't break. #SymfonyHackday Commits ------- 0f8ce65 [Mesenger] Mention that some option doesn't have docs
This PR was merged into the 6.4 branch. Discussion ---------- [Serializer] Add missing argument In the example, the `$context` is constructed, but then forgot to be passed to the `serializer`. This functionality is first documented in 6.4, hence I target this branch. Commits ------- d94be3f Add missing argument
* 6.4: Add missing argument [Mesenger] Mention that some option doesn't have docs
* 7.1: Add missing argument [Mesenger] Mention that some option doesn't have docs
* 7.2: Add missing argument Added replacement suggestions for forbidden directives [symfony#19940] Use specialized directive Add more necessary information Remove obsolete whitelist entry Update calling_commands.rst - call the command non interactively [HttpFoundation] Update http response test constraint signature add symfonycasts links in frontend doc [Serializer] Add class/format/context to NameConverterInterface [Mesenger] Mention that some option doesn't have docs
…ocesses deployment (pgorod) This PR was submitted for the 7.2 branch but it was squashed and merged into the 6.4 branch instead. Discussion ---------- [Scheduler] Add some pointers regarding worker processes deployment It took me quite some effort to figure this out... https://stackoverflow.com/questions/79257466/how-does-symfony-scheduler-component-get-triggered/79257514 It's one of those things that are obvious _after_ you know them, and where you should be looking for them, but not before... I think the specific mentions of "cron" in the text are valuable (because people will search for it), even though it's not the wisest option (when compared to supervisor etc). The link will take them to the best-practices. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `7.x` for features of unreleased versions). --> Commits ------- b38b1fa [Scheduler] Add some pointers regarding worker processes deployment
* 6.4: Minor tweaks [Scheduler] Add some pointers regarding worker processes deployment
* 7.1: Minor tweaks [Scheduler] Add some pointers regarding worker processes deployment
* 7.2: Minor tweaks [Scheduler] Add some pointers regarding worker processes deployment
fix a problem to load "Style" (see : https://frankenphp.dev/docs/early-hints/)
…le" (arnolem) This PR was submitted for the 7.2 branch but it was merged into the 6.4 branch instead. Discussion ---------- FIX : Early Hint 103 - fix a problem to load "Style" fix a problem to load "Style" (see : https://frankenphp.dev/docs/early-hints/) Commits ------- b16b567 Update controller.rst
* 6.4: Update controller.rst
* 7.1: Update controller.rst
* 7.2: Update controller.rst
…tion (Korbeil) This PR was merged into the 7.2 branch. Discussion ---------- [TypeInfo] Add more details to TypeInfo documentation This pull request is to revamp current TypeInfo documentation. I tried to make the most of the recent changes while answering `@javiereguiluz`'s issue (thanks to "PHPDoc parsing" part). It should fixes symfony#20389, symfony#20064 and symfony#20014. Commits ------- dc999f3 Add more details to TypeInfo documentation
* 7.2: Minor reword Add more details to TypeInfo documentation
…tTime` (SebLevDev) This PR was merged into the 7.3 branch. Discussion ---------- [Console] Add support of millisecondes for `formatTime` Fixe symfony#20460 Commits ------- b66e743 [Console] Add support of millisecondes for formatTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP